Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 2efe4ab76166
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: e9170cbc3d3a
Choose a head ref
  • 8 commits
  • 378 files changed
  • 2 contributors

Commits on Jun 6, 2014

  1. string_decoder: Improve test coverage 

    The test cases are still essentially the same, but now all possible ways
of writing a buffer into the decoder are tested, which has exposed a few
failing scenarios that had not been discovered so far!
    @felixge @tjfontaine
    felixge authored and tjfontaine committed Jun 6, 2014
    Copy the full SHA
    22b8398 View commit details
    Browse the repository at this point in the history

  2. string_decoder: Fix failures from new test cases 

    This patch simplifies the implementation of StringDecoder, fixes the
failures from the new test cases, and also no longer relies on v8's
WriteUtf8 function to encode individual surrogates.
    @felixge @tjfontaine
    felixge authored and tjfontaine committed Jun 6, 2014
    Copy the full SHA
    9fbd0f0 View commit details
    Browse the repository at this point in the history

  3. string_decoder: Add more comments

    @felixge @tjfontaine
    felixge authored and tjfontaine committed Jun 6, 2014
    Copy the full SHA
    80eff96 View commit details
    Browse the repository at this point in the history

  4. deps/v8: Apply REPLACE_INVALID_UTF8 patch 

    - https://codereview.chromium.org/121173009/
- https://code.google.com/p/v8/source/detail?r=18683

Note: The v8 test case did not cleanly apply, so it's missing from this
patch. I'm assuming this is not a problem if the v8 test suite is not
part of the node build / test system. If that's the case I'll fix it.
Otherwise the test case will be integrated once v8 is upgraded.
    @felixge @tjfontaine
    felixge authored and tjfontaine committed Jun 6, 2014
    Copy the full SHA
    881ac26 View commit details
    Browse the repository at this point in the history

  5. string_bytes: Guarantee valid utf-8 output 

    Previously v8's WriteUtf8 function would produce invalid utf-8 output
when encountering unmatched surrogate code units [1]. The new
REPLACE_INVALID_UTF8 option fixes that by replacing invalid code points
with the unicode replacement character.

[1]: JS Strings are defined as arrays of 16 bit unsigned integers. There
is no unicode enforcement, so one can easily end up with invalid unicode
code unit sequences inside a string.
    @felixge @tjfontaine
    felixge authored and tjfontaine committed Jun 6, 2014
    Copy the full SHA
    0da4c67 View commit details
    Browse the repository at this point in the history

  6. src: replace usage of String::Utf8Value 

    v8::String::Utf8Value previously could allow invalid surrogates when
interpreting values.
    @tjfontaine
    tjfontaine committed Jun 6, 2014
    Copy the full SHA
    535c777 View commit details
    Browse the repository at this point in the history

  7. npm: upgrade to v1.4.14

    @tjfontaine
    tjfontaine committed Jun 6, 2014
    Copy the full SHA
    f051f31 View commit details
    Browse the repository at this point in the history

  8. v8: shift heap space for aslr on 64bit 

    Previously we were only shifting the address space for ASLR on 32bit
processes, apply the same shift for 64bit so processes don't
get artificially limited native heap.
    @tjfontaine
    tjfontaine committed Jun 6, 2014
    Copy the full SHA
    e9170cb View commit details
    Browse the repository at this point in the history