Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: b71100f62ab9
Choose a base ref
...
head repository: cdk/cdk
compare: 605063ca7e51
Choose a head ref
  • 14 commits
  • 17 files changed
  • 1 contributor

Commits on Jan 18, 2014

  1. Move Elements from standard to core. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    5772ef3 View commit details
    Browse the repository at this point in the history

  2. NaturalElement can and should be package-private. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    c0dae6f View commit details
    Browse the repository at this point in the history

  3. Enumeration of chemical elements - avoids the slow startup of Periodi… 

    …cTable.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    df1064c View commit details
    Browse the repository at this point in the history

  4. In future the enumeration could implement ‘IElement’ directly but thi… 

    …s isn’t possible due to IChemObject needing to be cloneable. For now this is a work around - it does mean there is a Carbon and a CARBON which are different types but it’s a step in the right direction.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    9579dd5 View commit details
    Browse the repository at this point in the history

  5. Allow Ununquadium and Ununhexium to resolve to Flerovium and Livermor… 

    …ium.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    5ba696f View commit details
    Browse the repository at this point in the history

  6. IUPAC element naming with alternative spelling resolution. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    e73cb93 View commit details
    Browse the repository at this point in the history

  7. Static utilise should be public. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    775479a View commit details
    Browse the repository at this point in the history

  8. Periodic table now delegates to the new enumeration. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    b1180d7 View commit details
    Browse the repository at this point in the history

  9. All package-private classes are no longer useful and can be safely re… 

    …moved (there were not exposed in the public API).

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    43fdb6e View commit details
    Browse the repository at this point in the history

  10. The files may still be useful for reference but do need to be bundled… 

    … with ‘cdk-core’.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    47a3979 View commit details
    Browse the repository at this point in the history

  11. Minor documentation update and formatting - we could also deprecate t… 

    …his class but for now it is used quite widely.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    2ce58a6 View commit details
    Browse the repository at this point in the history

  12. A null string is an unknown element. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    a4c2e23 View commit details
    Browse the repository at this point in the history

  13. An unknown element now has atomic number 0 - note this was previously… 

    … the case when the symbol was ‘R’ but was null otherwise. Now all unknown elements have an atomic number of 0.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    0b133f3 View commit details
    Browse the repository at this point in the history

  14. Periodic table now never returns null - this condition isn’t right ‘[… 

    …Cd]’ and ‘*’ have the same fingerprint because ‘0’ = 48 (atomic number). There are however tests depending on the correct bits being set so not sure if it’s easy to change.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Jan 18, 2014
    Copy the full SHA
    605063c View commit details
    Browse the repository at this point in the history