[fix] merge #495, thanks @glasser

http-party · Nov 7, 2013 · d0862af · d0862af
1 parent cde08fb
commit d0862af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/http-proxy.js b/lib/http-proxy.js
@@ -36,7 +36,7 @@ proxy.createProxyServer = proxy.createServer = function createProxyServer(option
    *    `options.target and `options.forward` cannot be    
    *    both missing                                       
    *  }
-  */
+   */
 
   return new httpProxy.Server(options);
 };

diff --git a/lib/http-proxy/passes/ws-incoming.js b/lib/http-proxy/passes/ws-incoming.js
@@ -106,15 +106,11 @@ var passes = exports;
       common.setupOutgoing(options.ssl || {}, options, req)
     );
     // Error Handler
-    proxyReq.on('error', function(err){
-      if (clb) {
-        clb(err);
-      } else {
-        server.emit('error', err, req, res);
-      }
-    });
+    proxyReq.on('error', onError);
 
     proxyReq.on('upgrade', function(proxyRes, proxySocket, proxyHead) {
+      proxySocket.on('error', onError);
+
       common.setupSocket(proxySocket);
 
       if (proxyHead && proxyHead.length) proxySocket.unshift(proxyHead);
@@ -126,7 +122,15 @@ var passes = exports;
       proxySocket.pipe(socket).pipe(proxySocket);
     });
 
-    proxyReq.end(); // XXX: CHECK IF THIS IS THIS CORRECT
+    return proxyReq.end(); // XXX: CHECK IF THIS IS THIS CORRECT
+
+    function onError(err) {
+      if (clb) {
+        clb(err);
+      } else {
+        server.emit('error', err, req, res);
+      }
+    }
   }
 
 ] // <--