Added cluster configuration to describe request #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,6 +84,7 @@ public Response describeModeshape() throws IOException, RepositoryException { | |||
| } | |||
|
|
|||
| @GET | |||
| @Timed | |||
| @Produces({TEXT_XML, APPLICATION_XML, APPLICATION_JSON}) | |||
There was a problem hiding this comment.
I think we should try to bury this scary ISPN-specific logic in a service or something. ideally, I think, the http apis know only about fcrepo-* modules and the JCR API.
There was a problem hiding this comment.
👍 to that, and I'll go as far as to say that ideally, fcrepo-http-* only knows about other fcrepo code, not even JCR code. But that's an ideal towards which to move, not a goal to be met. :)
|
I made slight adjustments to move dependencies on modeshape and infinispan APIs into the kernel. It has been merge and pushed to master. |
dbernstein
added a commit
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/48423147