added support for http basic auth in JVM URL #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstrachan
added a commit
that referenced
this pull request
Apr 19, 2013
added support for http basic auth in JVM URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Auth
When securing jolokia using http basic auth, the current implementation does not pass the credentials from the JVM url down to
jolokia.js. For example, usinghttp://user:pass@example.com/jolokia/as the JVM URL will fail, as every ajax request will be send without authentication headers.Proxies
Additionally when running jolokia behind some proxy like nginx, the basic auth will fail due to the
jolokia.jslibrary not setting theAuthenticationheader and relying on jquerys on-demand authentication, which is not supported by all servers.See jolokia/jolokia#98 for details.