Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy children #375

Closed
wants to merge 2 commits into from
Closed

Conversation

lsitu
Copy link
Contributor

@lsitu lsitu commented May 21, 2014

https://www.pivotaltracker.com/s/projects/684825/stories/71611298
@awoods: I think the getChildren() method should be working as expected, and we should in a better position with the transparent hierarchy approach now. I also added a static getChildren() method in FedoraResourceImpl.java for convenient use, and integrated it to the HierarchyRdfContext.java for the REST web UI display so that you can evaluate the approach without any delays.

lsitu added 2 commits May 21, 2014 13:24
FedoraResourceImpl.java, and exposing the hierarchy levels through the
IdentifierConverter and IdentifierTranslator on behalf of the
getChildren() implementation.
@lsitu lsitu mentioned this pull request May 21, 2014
* Get hierarchy levels for path conversion
* @return
**/
public int getLevels() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getLevels() method seems to be a better fit for the IdentifierTranslator interface. Is there a reason that you chose IdentifierConverter instead?
If not, let's go with IdentifierTranslator.

@lsitu lsitu closed this May 22, 2014
@lsitu lsitu deleted the hierarchy_children branch May 22, 2014 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants