fix for trunk-8483 and trunk-4322 #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@milinda-ruk can you add some unit tests for these changes? |
|
Hi Daniel, |
|
Is these fixes merged ? Thanks! |
|
@milinda-ruk did you pull with --rebase as per this page? https://wiki.openmrs.org/display/docs/Pull+Request+Mistakes Secondly, every time you finish a branch and want to create another, you need to first switch to the master branch. So can you do that, then create a new branch and put in your changes? |
|
Hi @dkayiwa , Ok i will send the both pull requests again ASAP. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Darius,
This is my initial commit for the above tickets. Can you please review it and let me know if it needs more fixes.
Thanks!