Trunk 4011 #386
Closed
Trunk 4011 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return List<dependentModules> the list of moduleId's which depend on the module about to be shutdown. | ||
| * @since 1.10 | ||
| */ | ||
| public static List<String> validateDependencies(String moduleId) { |
There was a problem hiding this comment.
This should be getDependencies, validate is kind of misguiding given what the method does
| }); | ||
| }else{ | ||
| moduleId = escapeSpecialCharacters(moduleId); | ||
| $j('#' + moduleId + '-form').append('<input type="hidden" name="stop.x" value="stop.x">'); |
There was a problem hiding this comment.
This is causing a bug, a user can nolonger remove a module, you need to use the isUnloadFlag flag here and chose if to remove Vs stop the module as before
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all required changes, including validation/support for instances where a module id may contain special characters (ex. webservices.rest)
Thank you @rafal for all the debugging and consultation support :-)