Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
clean up a little; may remove start/end flipping completely (GIGO)
  • Loading branch information
Chris Fields committed Feb 28, 2012
1 parent 4c782b8 commit 3e471cf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions lib/Biome/Location/Simple.pm
Expand Up @@ -17,8 +17,6 @@ with 'Biome::Role::Location::Locatable';

sub BUILD {
my ($self, $params) = @_;

# this should probably just fail validation, seems clunky to handle it here
if ($params->{start} && $params->{end} && ($params->{end} < $params->{start})) {
$self->warn('End is greater than start; flipping strands');
$self->end($params->{start});
Expand Down
3 changes: 0 additions & 3 deletions lib/Biome/SeqFeature/Generic.pm
Expand Up @@ -12,15 +12,12 @@ with 'Biome::Role::SeqFeature';

sub BUILD {
my ($self, $params) = @_;

if ($params->{start} && $params->{end} && ($params->{end} < $params->{start})) {
$self->warn('End is greater than start; flipping strands');
$self->end($params->{start});
$self->start($params->{end});
$self->strand($self->strand * -1);
}

$params->{location_type} && $self->location_type($params->{location_type});
}

__PACKAGE__->meta->make_immutable;
Expand Down

0 comments on commit 3e471cf

Please sign in to comment.