Fix #2977: Error calling IO.write with a FIFO #3215
Conversation
| @@ -106,6 +106,30 @@ | |||
| IO.write(@filename, 'Hëllö'.encode('ISO-8859-1')) | |||
| File.binread(@filename).should == "H\xEBll\xF6".force_encoding(Encoding::ASCII_8BIT) | |||
| end | |||
|
|
|||
| platform_is_not :windows do | |||
| if `which mkfifo`.chomp != "" | |||
There was a problem hiding this comment.
We don't want random conditionals like these in specs, it should instead be a proper guard. I'm also not sure if we want to rely on shell executables for this in the first place.
There was a problem hiding this comment.
I see. I actually saw similar code under spec/ and thought it was the preferred way to do it. I'll remove the conditional and also use the appropriate library functions instead of shell executables.
Thanks for the feedback.
Edit: It seems like there is no way to mkfifo without relying on the system command 'mkfifo'. I guess this justifies why mkfifo is done this way in the spec files I referred to. I found a gem 'mkfifo' but I guess it is also not a good idea to bring it in as a dependency. I'll still replace the call to 'cat' with a proper Ruby file read.
Remove unneeded conditional Use IO.read instead of `cat`
|
@skliew thanks! |
Fix #2977: Error calling IO.write with a FIFO
In MRI, IO.write opens a file with a default mode of File::RDONLY, and does not seek if offset is not given. Fixing these would have rubinius' IO.write behave like MRI's when it's called with a FIFO.