Code cleanup in excel_xml_export.php

dregad · dregad · commit a3eec4b7b5e8 · 2012-03-09T13:09:13.000+01:00
Removed the specific logic to handle the extended text fields, which is no longer required as the BugData API will automatically retrieve them if needed. This is a leftover from the conversion from old, array-style access to bug data (see 18ad379). Furthermore, the call to bug_get() was redundant, since the result set from filter_get_bug_rows() already contains BugData objects. Fixes #14017 Also removes a useless line of code accidentally left in there by commit b5450f3.
diff --git a/excel_xml_export.php b/excel_xml_export.php
@@ -70,8 +70,6 @@
 
 	do {
 		foreach( $result as $t_row ) {
-			$t_bug = null;
-
 			if ( is_blank( $f_export ) || in_array( $t_row->id, $f_bug_arr ) ) {
 				echo excel_get_start_row();
 
@@ -83,15 +81,7 @@
 						echo excel_format_plugin_column_value( $t_column, $t_row );
 					} else {
 						$t_function = 'excel_format_' . $t_column;
-						if ( column_is_extended( $t_column ) ) {
-							if( $t_bug === null ) {
-								$t_bug = bug_get( $t_row->id, /* extended = */ true );
-							}
-							echo $t_function( $t_bug->$t_column );
-						} else {
-							$t_function = 'excel_format_' . $t_column;
-							echo $t_function( $t_row );
-						}
+						echo $t_function( $t_row );
 					}
 				}
 
@@ -106,7 +96,6 @@
 		if ( $t_more ) {
 			$t_page_number++;
 			$result = filter_get_bug_rows( $t_page_number, $t_per_page, $t_page_count, $t_bug_count );
-			$t_more !== false;
 		}
 	} while ( $t_more );
 
