Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3c8e9b017c88
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02b8d64ed373
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Nov 12, 2014

  1. Revert "Tag specs that don't pass in MRI 2.2 either." 

    This reverts commit c8d4441.
    @headius
    headius committed Nov 12, 2014
    Copy the full SHA
    ee57895 View commit details

  2. Put these in the right place.

    @headius
    headius committed Nov 12, 2014
    Copy the full SHA
    02b8d64 View commit details
1 change: 1 addition & 0 deletions spec/tags/ruby/core/module/attr_accessor_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Module#attr_accessor allows creating an attr_accessor on an immediate class
1 change: 1 addition & 0 deletions spec/tags/ruby/core/module/attr_reader_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Module#attr_reader allows for adding an attr_reader to an immediate
1 change: 1 addition & 0 deletions spec/tags/ruby/core/module/attr_writer_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Module#attr_writer allows for adding an attr_writer to an immediate
1 change: 0 additions & 1 deletion spec/truffle/tags/core/module/attr_accessor_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -4,4 +4,3 @@ fails:Module#attr_accessor converts non string/symbol/fixnum names to strings us
fails:Module#attr_accessor raises a TypeError when the given names can't be converted to strings using to_str
fails:Module#attr_accessor applies current visibility to methods created
fails:Module#attr_accessor is a private method
fails(2.2 change):Module#attr_accessor allows creating an attr_accessor on an immediate class
1 change: 0 additions & 1 deletion spec/truffle/tags/core/module/attr_reader_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -4,4 +4,3 @@ fails:Module#attr_reader converts non string/symbol/fixnum names to strings usin
fails:Module#attr_reader raises a TypeError when the given names can't be converted to strings using to_str
fails:Module#attr_reader applies current visibility to methods created
fails:Module#attr_reader is a private method
fails(2.2 change):Module#attr_reader allows for adding an attr_reader to an immediate
1 change: 0 additions & 1 deletion spec/truffle/tags/core/module/attr_writer_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -4,4 +4,3 @@ fails:Module#attr_writer converts non string/symbol/fixnum names to strings usin
fails:Module#attr_writer raises a TypeError when the given names can't be converted to strings using to_str
fails:Module#attr_writer applies current visibility to methods created
fails:Module#attr_writer is a private method
fails(2.2 change):Module#attr_writer allows for adding an attr_writer to an immediate