-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some error with RG with embedded JRuby #2343
Comments
@mkristian e9f5e96 can you revert this and confirm your problem goes away for me. tb3 integs also do not like this rg update and I would really like to see 1.7.18 today tomorrow. We will figure out whatever we need for rg update for 1.7.19. |
We can revert, but RG 2.4.5 is in the wild...people are going to end up loading and using it. We need to figure this out, obviously. |
@headius I would rather release with this outstanding than try and mad dash it in a few hours to end up bungling something else. Going to mark this against 1.7.19. |
Right, I agree we should revert for 1.7.18 release. We just can't leave it that way forever :-) |
the problem with using embedded jruby that there is no way to upgrade or |
from the nexus-osss side it is OK to revert 53afbbb and get RG-2.4.5 in. the issue was that running gem commands do keep state and running several commands within one runtime is problematic. some of this internal state changed and let the tests fail. |
https://github.com/sonatype/nexus-oss/blob/nexus-2.11.x/testsuite/modern-testsuite/src/test/java/org/sonatype/nexus/testsuite/ruby/GemLifecycleIT.java#L66
this line fails which basically executes
gem list --clear-source -sources http://localhost:7898/nexus/rubygems -r
it is ONLY a failure in the test-client, the server side tests passes when jruby-1.7.18-SNAPSHOT on the server and jruby-1.7.17 on the client. it also passes if I revert the RubyGems-2.4.5 commit: e9f5e96
using jruby-1.7.17 on nexus-oss is quite important since it is the first version since 1.7.12 which works again and it reduces the "startup" time of ScriptingContainer from 20s to 8s on my machine.
mri-1.9.3-p551 - the latest 1.9 version I found on rbenv does come with RG 1.8.23.2
maybe jruby could stay with a version of RG within the range 2.1.x
The text was updated successfully, but these errors were encountered: