Skip to content

Commit

Permalink
Set default value for ENABLE_REDIS to 0
Browse files Browse the repository at this point in the history
  • Loading branch information
@sfan5
sfan5 committed Jan 10, 2015
1 parent 30334b6 commit 8089d89
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Expand Up @@ -295,7 +295,7 @@ endif(ENABLE_LEVELDB)

set(USE_REDIS 0)

OPTION(ENABLE_REDIS "Enable redis backend" 1)
OPTION(ENABLE_REDIS "Enable redis backend" 0)

if(ENABLE_REDIS)
find_library(REDIS_LIBRARY hiredis)
Expand Down

4 comments on commit 8089d89

@ShadowNinja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redis block should be in cmake/Modules/FindRedis.cmake.

@sfan5
Copy link
Member Author

@sfan5 sfan5 commented on 8089d89 Jan 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to have a seperate file for each library or what?

@ShadowNinja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfan5 Yes, that's how we do it. See the other files in that folder. It reduces the length of the main file and you can use find_package_handle_standard_args for even more code reduction.

@Calinou
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not enable both LevelDB and Redis if the respective libraries are found? There could be a warning in case these libraries are not found, but Minetest would still compile with support disabled for them.

Please sign in to comment.