fixed extends, layout and title helpers not to generate unnecessary l…

…og messages
mojolicious · May 20, 2013 · dcc4f1f · dcc4f1f
1 parent 57a882f
commit dcc4f1f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,4 +1,8 @@
 
+4.02  2013-05-20
+  - Fixed extends, layout and title helpers not to generate unnecessary log
+    messages.
+
 4.01  2013-05-19
   - Fixed small drain event bug in Mojo::IOLoop::Stream. (ChinaXing)
 

diff --git a/lib/Mojolicious.pm b/lib/Mojolicious.pm
@@ -41,7 +41,7 @@ has static   => sub { Mojolicious::Static->new };
 has types    => sub { Mojolicious::Types->new };
 
 our $CODENAME = 'Top Hat';
-our $VERSION  = '4.01';
+our $VERSION  = '4.02';
 
 sub AUTOLOAD {
   my $self = shift;

diff --git a/lib/Mojolicious/Plugin/DefaultHelpers.pm b/lib/Mojolicious/Plugin/DefaultHelpers.pm
@@ -12,13 +12,15 @@ sub register {
     $app->helper($name => sub { shift->$name(@_) });
   }
 
-  # Stash key shortcuts
+  # Stash key shortcuts (should not generate log messages)
   for my $name (qw(extends layout title)) {
     $app->helper(
       $name => sub {
-        my $self = shift;
-        $self->stash($name => @_) if @_;
-        return $self->stash->{$name};
+        my $self  = shift;
+        my $stash = $self->stash;
+        $stash->{$name} = shift if @_;
+        $self->stash(@_) if @_;
+        return $stash->{$name};
       }
     );
   }