added label to FedoraObject #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return A label associated with this object. Normally stored in a String-valued dc:title property. | ||
| * @throws RepositoryException | ||
| */ | ||
| public String getLabel() throws RepositoryException { |
There was a problem hiding this comment.
Maybe FedoraObject and Datastream should inherit from a base class that provides label-fetching methods?
|
That would a hypothetical FedoraResource? (Matching the JCR types.) |
| Repository repo; | ||
|
|
||
| @Test | ||
| public void testLabel() throws RepositoryException, IOException { |
There was a problem hiding this comment.
Can we also have a test showing what happens when you set the label, and then set the label again?
|
Indeed, a FedoraResource. |
…ed test cases for it, are you happy chris? ARE YOU?
birkland
pushed a commit
to birkland/fcrepo4
that referenced
this pull request
Jul 22, 2016
Link to Quick Start with WebAC guide on the wiki.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.