Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 03b00dcca912
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 1f76a2eddc35
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 4, 2012

  1. fs: fix 'object is not a function' callback errors

    Use a default callback if the user omitted one. Avoids errors like the one
    below:
    
      fs.js:777
          if (err) return callback(err);
                          ^
      TypeError: object is not a function
              at fs.appendFile (fs.js:777:21)
              at Object.oncomplete (fs.js:297:15)
    
    This commit fixes the behavior of fs.lchmod(), fs.lchown() and fs.readFile()
    when the callback is omitted. Before, they silently swallowed errors.
    
    Fixes #4352.
    bnoordhuis committed Dec 4, 2012
    Copy the full SHA
    a804347 View commit details
    Browse the repository at this point in the history
  2. fs: add long stacktrace debugging facility

    Enable long stacktraces if NODE_DEBUG=fs is set in the environment. Only
    applies to the default rethrow callback; it's to help you find places where
    you forgot to pass in a callback.
    bnoordhuis committed Dec 4, 2012
    Copy the full SHA
    1f76a2e View commit details
    Browse the repository at this point in the history