Move recent change log parsing to release controller

We don't need to do it for the pod controller.
metacpan · Mar 20, 2014 · e174e9e · e174e9e
1 parent 6bf5456
commit e174e9e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/MetaCPAN/Web/Controller/Release.pm b/lib/MetaCPAN/Web/Controller/Release.pm
@@ -62,6 +62,7 @@ sub view : Private {
         {
             files   => $model->interesting_files( $author, $release ),
             modules => $model->modules( $author,           $release ),
+            changes => $c->model('API::Changes')->get( $author, $release ),
         },
         $out,
     );
@@ -105,6 +106,9 @@ sub view : Private {
         push @view_files, $h;
     }
 
+    my $changes
+        = $c->model('API::Changes')->last_version( $reqs->{changes}, $out );
+
     # TODO: make took more automatic (to include all)
     $c->stash(
         {
@@ -118,6 +122,7 @@ sub view : Private {
             root     => \@root_files,
             examples => \@examples,
             files    => \@view_files,
+            ( $changes ? ( last_version_changes => $changes ) : () ),
         }
     );
 }

diff --git a/lib/MetaCPAN/Web/Role/ReleaseInfo.pm b/lib/MetaCPAN/Web/Role/ReleaseInfo.pm
@@ -39,8 +39,6 @@ sub api_requests {
             $c->model('API::Release')->versions( $data->{distribution} ),
         distribution =>
             $c->model('API::Release')->distribution( $data->{distribution} ),
-        changes =>
-            $c->model('API::Changes')->get( $data->{author}, $data->{name} ),
         %$reqs,
     };
 }
@@ -49,9 +47,6 @@ sub api_requests {
 sub stash_api_results {
     my ( $self, $c, $reqs, $data ) = @_;
 
-    my $changes
-        = $c->model('API::Changes')->last_version( $reqs->{changes}, $data, );
-
     $c->stash(
         {
             author => $reqs->{author},
@@ -62,7 +57,6 @@ sub stash_api_results {
             versions     => [
                 map { $_->{fields} } @{ $reqs->{versions}->{hits}->{hits} }
             ],
-            ( $changes ? ( last_version_changes => $changes ) : () ),
         }
     );
 }