store a reference to the txid within the session #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(needed to start simplifying the HttpGraphSubjects API to the point where it can be injected rather than instantiated EVERYWHERE) |
…cation, not constructor
|
Ok @barmintor, I think this is ready to go. We're storing the txid as a transient property on the session (ugly, but I tried to wrap it in some fcrepo APIs so we can change our mind later) so we can pass the plain, non-wrapped session around (as modeshape does internally) and get our tx back. |
ghost
assigned 
|
My only comment is to remind us all to start a conversation with the MODE folks about this. I hope and believe that they will be happy to see people extending the semantics of Session and will want to support us doing this in a cleaner way. |
|
@ajs6f I've now noted that as https://www.pivotaltracker.com/story/show/53336253 |
cbeer
added a commit
that referenced
this pull request
Jul 18, 2013
store a reference to the txid within the session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly hack, but at least plain sessions can provide enough information about a tx they may or may not be a part of