Commits on May 24, 2013

1. unix: fix stream refcounting buglet …

   Fix a buglet where uv_read_stop() would mark the handle as stopped even
   when there are in-progress write requests.
   
   This bug is unlikely to have affected anyone, the only case where it
   has a user-visible effect is when:
   
     a) the handle has been stopped for reading but not writing, and
     b) it's the last active handle in the event loop's pollset
   
   If both conditions are met, it's possible for the event loop to
   terminate prematurely.
   
   This reapplies commit 80f2f82 which was temporarily reverted in fe7b154
   because it was making a lot of node.js tests fail on OS X with the
   following assertion:
   
       Assertion failed: (!uv__is_active(handle)), function
       uv__finish_close, file ../../deps/uv/src/unix/core.c, line 165.
   
   Expecting that the handle is inactive when the state is UV_CLOSING
   turns out to be a bad assumption: it's possible that the handle is
   executing (for example) a shutdown request when uv__finish_close()
   is called. That's okay, uv__stream_destroy() takes care of that.
   
   The issue wasn't specific to OS X, it was just more visible on that
   platform. (Slow) debug builds on Linux exhibited the same behavior.

   

   bnoordhuis committed May 24, 2013
   Copy the full SHA

   636a13b View commit details

   Browse the repository at this point in the history