Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 8aabc20852f2
Choose a base ref
...
head repository: PDLPorters/pdl
compare: a3e4397a49c5
Choose a head ref
  • 6 commits
  • 8 files changed
  • 3 contributors

Commits on Jul 3, 2012

  1. Minor cleanups to pdl_from_string.t, inline-comment-test.t 

    While working on a few other files in the test suite, I came across
the code in inline-comment-test.t that is supposed to ensure that
the tests are only run on machines that are configured properly to
execute the tests. The code was a bit confusing, so I cleaned it up
in a way that I hope makes it easier for others to follow in the
future.

I also expanded the explanation of the test that is given at the
top of pdl_from_string, since support for inf and nan values is
now one of the goals of the pdl-from-string behavior.
    @run4flat
    run4flat committed Jul 3, 2012
    Copy the full SHA
    19979b1 View commit details
    Browse the repository at this point in the history

  2. Fixed nan sign issue, as reported by Matthew McGillis 

    I had noticed that pdl-from-string always said that 'nan' had a
minus sign, but I didn't bother much about it. Matthew McGillis
not only knew better, but wrote a patch to fix the situation,
which is applied here.

The only remaining issue is now the sign of -0, which Matthew
included in his tentative test suite but which does not appear to
work on my machine. Further investigations are needed...
    @run4flat
    run4flat committed Jul 3, 2012
    Copy the full SHA
    000212d View commit details
    Browse the repository at this point in the history

  3. Provide (basic) testing for lgamma function. 

    Previously untested.
    @sisyphus
    sisyphus committed Jul 3, 2012
    Copy the full SHA
    3f9928f View commit details
    Browse the repository at this point in the history

  4. Add lgamma() implementation for MinGW-built perls. 

    The MinGW ports of gcc provide an lgamma() function.
Let's make use of it - as has already been done for
*nix systems.
    @sisyphus
    sisyphus committed Jul 3, 2012
    Copy the full SHA
    b67e2e9 View commit details
    Browse the repository at this point in the history

  5. MANIFEST - add t/lgamma.t

    @sisyphus
    sisyphus committed Jul 3, 2012
    Copy the full SHA
    88a9fff View commit details
    Browse the repository at this point in the history

  6. make qsort[vec] inplace aware 

    Applying the patch by Tim Haines.  Thanks.
    @devel-chm
    Tim Haines authored and devel-chm committed Jul 3, 2012
    Copy the full SHA
    a3e4397 View commit details
    Browse the repository at this point in the history