Velocity templates should be called for ascenedant primary types #484
Conversation
| boolean templateFound = false; | ||
| for (NodeType superType : primaryNodeType.getSupertypes()) { | ||
| // for each node primary type, we try to find a template | ||
| templateLocation = |
There was a problem hiding this comment.
Refactor much of this code block into a new private method that can be called here and in line:145
There was a problem hiding this comment.
And please strongly consider using the more concise and understandable Guava [Iterables.getFirst()](http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/Iterables.html#getFirst%28java.lang.Iterable, T%29).
There was a problem hiding this comment.
Since I'm refactoring this code to only be called once, shall I just keep it in-line?
There was a problem hiding this comment.
You're going to need to call it inside of a Predicate, but then call it again once you know which mixin on which to rely, so I would factor it out anyway.
Update to Modeshape 4.0.0.Final
Added fixity properties to the fcr:fixity result page.
Conflicts: fcrepo-http-api/src/main/java/org/fcrepo/http/api/FedoraFixity.java fcrepo-http-api/src/main/java/org/fcrepo/http/api/responses/StreamingBaseHtmlProvider.java fcrepo-http-api/src/main/resources/views/fcr-fixity.vsl
|
Hello @nikhiltri and @awoods, If this PR is no longer necessary, could one of you please close it? If we don't hear from you by November 20th, 2015, we'll close this for you. Thank you! |
|
Closed due to age of PR. ...and this issue was resolved with a different PR. |
Fix for: https://www.pivotaltracker.com/s/projects/684825/stories/79207804