Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

Commit

Permalink
test: remove test-eio-overflow.c
Browse files Browse the repository at this point in the history
Unreliable, it's timing / system load sensitive.
  • Loading branch information
bnoordhuis committed May 24, 2012
1 parent ce28e13 commit 28766dc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 92 deletions.
89 changes: 0 additions & 89 deletions test/test-eio-overflow.c

This file was deleted.

2 changes: 0 additions & 2 deletions test/test-list.h
Expand Up @@ -154,7 +154,6 @@ TEST_DECLARE (fs_open_dir)
TEST_DECLARE (fs_rename_to_existing_file)
TEST_DECLARE (threadpool_queue_work_simple)
TEST_DECLARE (threadpool_multiple_event_loops)
TEST_DECLARE (eio_overflow)
TEST_DECLARE (thread_mutex)
TEST_DECLARE (thread_rwlock)
TEST_DECLARE (thread_create)
Expand Down Expand Up @@ -375,7 +374,6 @@ TASK_LIST_START
TEST_ENTRY (fs_rename_to_existing_file)
TEST_ENTRY (threadpool_queue_work_simple)
TEST_ENTRY (threadpool_multiple_event_loops)
TEST_ENTRY (eio_overflow)
TEST_ENTRY (thread_mutex)
TEST_ENTRY (thread_rwlock)
TEST_ENTRY (thread_create)
Expand Down
1 change: 0 additions & 1 deletion uv.gyp
Expand Up @@ -305,7 +305,6 @@
'test/test-connection-fail.c',
'test/test-cwd-and-chdir.c',
'test/test-delayed-accept.c',
'test/test-eio-overflow.c',
'test/test-fail-always.c',
'test/test-fs.c',
'test/test-fs-event.c',
Expand Down

3 comments on commit 28766dc

@shigeki
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis Thanks. All current tests in libuv have just been passed in my environment. I was going to make a patch to uv_timer instead for this test. How are you going to do with test-callback-order.c? It's been disabled. I wonder whether libuv is to be fixed or not.

@bnoordhuis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you going to do with test-callback-order.c? It's been disabled. I wonder whether libuv is to be fixed or not.

The test has been reworked in the next-tick branch (8143d76). It's TBD if we're going to define callback order with that level of detail.

@shigeki
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I understand test-next-tick-ordering2.js of Node is left to be failed for some time.

Please sign in to comment.