Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented checks for overlapping visits #653

Merged
merged 1 commit into from Mar 6, 2014

Conversation

WolfSchlegel
Copy link
Contributor

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Feb 21, 2014

@WolfSchlegel does the VisitValidatorTest tests pass on your side? If yes, do you have the latest changes from upstream? :)

@ghost
Copy link

ghost commented Mar 6, 2014

Hi @WolfSchlegel. In future please kindly use any relevant JIRA issue numbers in your pull request title, similar to that as described for commit messages in https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section "Work on your task". Thanks!

@dkayiwa
Copy link
Member

dkayiwa commented Mar 6, 2014

@WolfSchlegel Travis complains about this pull request. So i decided to get your changes and test them locally only to find that these tests fail:

Failed tests:
validate_shouldAcceptAVisitIfStartDateTimeFallsIntoAnotherVoidedVisitOfTheSamePatient(org.openmrs.validator.VisitValidatorTest)
validate_shouldAcceptAVisitIfStopDateTimeFallsIntoAnotherVoidedVisitOfTheSamePatient(org.openmrs.validator.VisitValidatorTest)
validate_shouldAcceptAVisitIfStartDateTimeIsEqualToStartDateTimeOfAnotherVoidedVisitOfTheSamePatient(org.openmrs.validator.VisitValidatorTest)
validate_shouldAcceptAVisitIfItContainsAnotherVoidedVisitOfTheSamePatient(org.openmrs.validator.VisitValidatorTest)

@dkayiwa
Copy link
Member

dkayiwa commented Mar 6, 2014

Could it be a date format issue? Am using a mac book. Are you using windows?

@dkayiwa dkayiwa merged commit 749a495 into openmrs:master Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants