[#TRUNK-4274] Order.encounter should be required #695
Conversation
| @@ -6420,6 +6420,22 @@ | |||
| upgrade process if any unmapped text is found | |||
| </comment> | |||
| </changeSet> | |||
|
|
|||
| <changeSet id="201403021223-TRUNK-4274" author="k-joseph" dbms="mysql"> | |||
There was a problem hiding this comment.
There is already a changeset to handle this see https://tickets.openmrs.org/browse/TRUNK-4283
Don't include dbms
There was a problem hiding this comment.
i added this changeset as a response to your comment on the ticket @wluyima that says; you need to add a changeset that should check that no order has a null encounter.
were you meaning this or something else, and if it was this then do i again need to address the changeset since it is requiring the same thing as does https://tickets.openmrs.org/browse/TRUNK-4283 ?
for the case of dbms, i realised some tests were failing on upgrade and yet would pass when i included it, that's why i added it there, in case there's need for this changeset again then i can try removing it again and run mvn clean install and if passes, well and good, i remove it,
There was a problem hiding this comment.
Leave out the dbms.
I probably made the comment before TRUNK-4283, so you can remove it.
|
Merged the code at ed4fd04 |
fix for https://tickets.openmrs.org/browse/TRUNK-4274 | made orders.encounter_id nullable, updated Update OrderService.discontinueOrder() and resolved the failing unit tests