Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
build: link with -rdynamic, not -Wl,--export-dynamic
Browse files Browse the repository at this point in the history
The system linker on SunOS doesn't understand --export-dynamic.
  • Loading branch information
bnoordhuis committed Jul 18, 2012
1 parent 98b1ce9 commit 5a5e128
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 1 addition & 4 deletions common.gypi
Expand Up @@ -148,7 +148,7 @@
[ 'OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
'cflags': [ '-Wall', '-pthread', ],
'cflags_cc': [ '-fno-rtti', '-fno-exceptions' ],
'ldflags': [ '-pthread', ],
'ldflags': [ '-pthread', '-rdynamic' ],
'conditions': [
[ 'target_arch=="ia32"', {
'cflags': [ '-m32' ],
Expand All @@ -158,9 +158,6 @@
'cflags': [ '-m64' ],
'ldflags': [ '-m64' ],
}],
[ 'OS=="linux"', {
'ldflags': [ '-rdynamic' ],
}],
[ 'OS=="solaris"', {
'cflags': [ '-pthreads' ],
'ldflags': [ '-pthreads' ],
Expand Down
1 change: 0 additions & 1 deletion node.gyp
Expand Up @@ -206,7 +206,6 @@
'src/node_signal_watcher.cc',
'src/node_io_watcher.cc',
],
'ldflags': [ '-Wl,--export-dynamic' ],

This comment has been minimized.

Copy link
@mscdex

mscdex Jul 18, 2012

Won't this break addon usage on freebsd again? This was just fixed in acbfc40.

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Jul 19, 2012

Author Member

It shouldn't. The stock gcc on my freebsd 9 box understands -rdynamic.

}],
[ 'OS=="mac"', {
'libraries': [ '-framework Carbon' ],
Expand Down

0 comments on commit 5a5e128

Please sign in to comment.