Skip to content

Commit

Permalink
mention that error events need to be handled in all classes
Browse files Browse the repository at this point in the history
  • Loading branch information
kraih committed Oct 29, 2013
1 parent 892e9c9 commit a7a0779
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/Mojo/IOLoop/Client.pm
Expand Up @@ -174,7 +174,7 @@ Emitted safely once the connection is established.
...
});
Emitted if an error occurs on the connection.
Emitted if an error occurs on the connection, fatal if unhandled.
=head1 ATTRIBUTES
Expand Down
3 changes: 2 additions & 1 deletion lib/Mojo/IOLoop/Delay.pm
Expand Up @@ -115,7 +115,8 @@ emit the following new ones.
...
});
Emitted if an error occurs in one of the steps, breaking the chain.
Emitted if an error occurs in one of the steps, breaking the chain, fatal if
unhandled.
=head2 finish
Expand Down
2 changes: 1 addition & 1 deletion lib/Mojo/IOLoop/Stream.pm
Expand Up @@ -204,7 +204,7 @@ Emitted safely once all data has been written.
...
});
Emitted if an error occurs on the stream.
Emitted if an error occurs on the stream, fatal if unhandled.
=head2 read
Expand Down
5 changes: 3 additions & 2 deletions lib/Mojo/Reactor.pm
Expand Up @@ -77,8 +77,9 @@ the following new ones.
...
});
Emitted for exceptions caught in callbacks. Note that if this event is
unhandled or fails it might kill your program, so you need to be careful.
Emitted for exceptions caught in callbacks, fatal if unhandled. Note that if
this event is unhandled or fails it might kill your program, so you need to be
careful.
$reactor->on(error => sub {
my ($reactor, $err) = @_;
Expand Down
3 changes: 2 additions & 1 deletion lib/Mojo/UserAgent.pm
Expand Up @@ -564,7 +564,8 @@ the following new ones.
...
});
Emitted if an error occurs that can't be associated with a transaction.
Emitted if an error occurs that can't be associated with a transaction, fatal
if unhandled.
$ua->on(error => sub {
my ($ua, $err) = @_;
Expand Down

0 comments on commit a7a0779

Please sign in to comment.