Fixity uris #202
Merged
Fixity uris #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "info:fedora2" + expected + "/bad"); | ||
| actual = testObj.getPathFromGraphSubject(mockSubject); | ||
| assertNull(actual); | ||
| // test a non-existent path |
There was a problem hiding this comment.
Is there any reason to remove this test? Is there any expected difference between a bad path with a bogus namespace and one with a good namespace?
There was a problem hiding this comment.
The diff is a little confusing. The check that was removed was "test a non-existent path", which isn't actually logic we have in any of the GraphSubject impls, and was only passing because it was also a "bad subject" like the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the fixity RDF response to use a PREMIS vocabulary, and use a hash-uri as the subject so it is "resolvable".
Also, switch back to using the "info:fedora/" namespace for the DefaultGraphSubjects (part of this PR because without it the fixity URIs generated using the DefaultGraphSubjects were invalid).