Fix code generation for op_asgn_1 calls (foo[bar] += 10)

opal · Jan 6, 2014 · a62a443 · a62a443
1 parent bafc36a
commit a62a443
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -92,6 +92,8 @@
 *   Support any Tilt template for `index_path` in `Opal::Server`. All index
     files are now run through `Tilt` (now supports haml etc).
 
+*   Fix code generation of `op_asgn_1` calls (foo[val] += 10).
+
 ## 0.5.5 2013-11-25
 
 *   Fix regression: add `%i[foo bar]` style words back to lexer

diff --git a/lib/opal/nodes/call_special.rb b/lib/opal/nodes/call_special.rb
@@ -77,7 +77,7 @@ def compile_operator
         with_temp do |a| # args
           with_temp do |r| # recv
             cur = s(:call, s(:js_tmp, r), :[], s(:arglist, s(:js_tmp, a)))
-            rhs = s(:call, cur, :+, s(:arglist, self.rhs))
+            rhs = s(:call, cur, op.to_sym, s(:arglist, self.rhs))
             call = s(:call, s(:js_tmp, r), :[]=, s(:arglist, s(:js_tmp, a), rhs))
 
             push "(#{a} = ", expr(first_arg), ", #{r} = ", expr(lhs)

diff --git a/spec/opal/core/runtime/operator_call_spec.rb b/spec/opal/core/runtime/operator_call_spec.rb
@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe "Operator calls" do
+  before { @obj = {:value => 10} }
+
+  it "compiles as a normal send method call" do
+    @obj[:value] += 15
+    @obj[:value].should == 25
+
+    @obj[:value] -= 23
+    @obj[:value].should == 2
+  end
+end