Fix Element#inspect for document and window

elia · elia · commit 8b8b884369ed · 2014-06-30T16:25:05.000+02:00
diff --git a/opal/opal-jquery/element.rb b/opal/opal-jquery/element.rb
@@ -259,6 +259,9 @@ def tag_name
 
   def inspect
     %x{
+      if      (self[0] === document) return '#<Element [document]>'
+      else if (self[0] === window  ) return '#<Element [window]>'
+
       var val, el, str, result = [];
 
       for (var i = 0, length = self.length; i < length; i++) {
diff --git a/spec/element/inspect_spec.rb b/spec/element/inspect_spec.rb
@@ -7,12 +7,24 @@
     <p id="lol" class="bar"></div>
   HTML
 
-  it "should return a string representation of the elements" do
+  it "returns a string representation of the elements" do
     Element.find('#foo').inspect.should == '#<Element [<div id="foo">]>'
     Element.find('.bar').inspect.should == '#<Element [<div class="bar">, <p id="lol" class="bar">]>'
   end
 
-  it "should return '[]' when called on empty element set" do
+  it "returns '[]' when called on empty element set" do
     Element.find('.inspect-spec-none').inspect.should == '#<Element []>'
   end
+
+  it "returns '[]' when called on empty element set" do
+    Element.find('.inspect-spec-none').inspect.should == '#<Element []>'
+  end
+
+  it "returns '[document]' when called on $(document)" do
+    Element.find(`document`).inspect.should == '#<Element [document]>'
+  end
+
+  it "returns '[window]' when called on $(window)" do
+    Element.find(`window`).inspect.should == '#<Element [window]>'
+  end
 end
