added automated tests for patient search #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When do you plan to finish this? |
|
Hi Daniel, I have implemented two new search methods and marked the old ones as deprecated. I noticed that HibernatePersonDAOTest has been merged with PersonDAOTest. Shall I move the new tests from HibernatePersonDAOTest to PersonDAOTest? Thanks, |
|
Oh yes please do. Thanks Wolf!!! :) |
|
Wow, that was quick. Will do right now. |
…ntDAO and org.openmrs.api.db.hibernate.PatientSearchCriteria Refactored org.openmrs.api.db.hibernate.PatientSearchCriteria Added and implemented org.openmrs.api.db.PatientDAO#getPatients(String,Integer,Integer) Added and implemented org.openmrs.api.db.PatientDAO#getCountOfPatients(String) Marked org.openmrs.api.db.PatientDAO#getPatients(String,String,List,boolean,Integer,Integer) as deprecated Marked org.openmrs.api.db.PatientDAO#getCountOfPatients(String,String,List,boolean,boolean) as deprecated Moved tests from org.openmrs.api.db.hibernate.HibernatePatientDAOTest to org.openmrs.api.db.PatientDAOTest
|
Done. |
|
Regarding the old search methods, I have found no usage in the OpenMRS core codebase that actually uses the List identifierTypes parameter. It is either an empty list or null. |
dkayiwa
added a commit
that referenced
this pull request
Jan 20, 2014
added automated tests for patient search
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored patient search criteria
integrated patient search with search by person attribute
task 2472 not finished, this commit is for an intermediate review