TRUNK-3203 Add JUnit test for getting by patients for method HibernatePa... #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,4 +273,38 @@ public void getPatientIdentifiers_shouldLimitByResultsByLocation() throws Except | |||
| Assert.assertEquals("12345K", patientIdentifiers.get(0).getIdentifier()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void getPatientIdentifiers_shouldLimitByResultsByPatientWithId2() throws Exception { | |||
There was a problem hiding this comment.
change shouldLimitResultsBy, try using the test generator plugin
…ePatientDAO.getPatientIdentifiers TRUNK-3203 Add JUnit test for getting by patients for method HibernatePatientDAO.getPatientIdentifiers review fixes TRUNK-3203 Add JUnit test for getting by patients for method HibernatePatientDAO.getPatientIdentifiers review fixes TRUNK-3203 Add JUnit test for getting by patients for method HibernatePatientDAO.getPatientIdentifiers review fixes TRUNK-3203 Add JUnit test for getting by patients for method HibernatePatientDAO.getPatientIdentifiers review fixes Add JUnit test for getting by patients for method HibernatePatientDAO.getPatientIdentifiers
| import org.junit.Assert; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.internal.matchers.TypeSafeMatcher; |
There was a problem hiding this comment.
You should have used a class from org.hamcrest
|
Made small suggested changes and merged with rebase in 79d94c3 Thanks Arek! |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
openmrs#226) * Added extension slot for external links in the app-menu * Removed the extension slot and added the code for fetching the links from the configuration. * Added visiblity option for external links * Added pre-push test back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUNK-3203 Add JUnit test for getting by patients for method HibernatePa...