Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 0308ad2ce53f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 304c0b43aa88
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 28, 2014

  1. Revert "crypto: cast uv_thread_t to unsigned long"

    This reverts commit 0308ad2.
    orangemocha committed Nov 28, 2014
    Copy the full SHA
    cb8cadb View commit details
    Browse the repository at this point in the history
  2. crypto: store thread id as pointer-sized

    In https://github.com/MSOpenTech/libuv/commit/59658a8de7cc05a58327a164fd2ed4b050f8b4f4
    the return of uv_thread_self() was changed from unsigned long to
    uv_thread_t.
    
    uv_thread_t is a HANDLE (pointer-sized) on Windows, which means that
    on Win64 it cannot be stored with CRYPTO_THREADID_set_numeric without
    data loss.
    
    Furthermore, without this change there will be a build break on Windows
    when the libuv change is integrated into Node, because of the
    conversion from HANDLE to unsigned long.
    
    Other related commits:
    5845a6b
    https://github.com/MSOpenTech/libuv/commit/919d8ec63ac53566ad1f090058ec15966bd0e960
    orangemocha committed Nov 28, 2014
    Copy the full SHA
    304c0b4 View commit details
    Browse the repository at this point in the history