unix: fix close-before-connect bug

Closing the TCP socket before the SYN/ACK handshake completed hung the event loop, the connect req didn't get unregistered.
joyent · May 17, 2012 · e82d464 · e82d464
1 parent e10a87a
commit e82d464
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/unix/stream.c b/src/unix/stream.c
@@ -129,6 +129,13 @@ void uv__stream_destroy(uv_stream_t* stream) {
 
   assert(stream->flags & UV_CLOSED);
 
+  if (stream->connect_req) {
+    uv__req_unregister(stream->loop, stream->connect_req);
+    uv__set_artificial_error(stream->loop, UV_EINTR);
+    stream->connect_req->cb(stream->connect_req, -1);
+    stream->connect_req = NULL;
+  }
+
   while (!ngx_queue_empty(&stream->write_queue)) {
     q = ngx_queue_head(&stream->write_queue);
     ngx_queue_remove(q);