Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 822abecdd0ce
Choose a base ref
...
head repository: jruby/jruby
compare: ce7e292dcc89
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Nov 5, 2014

  1. Exclude new Ripper failures.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    a9d1364 View commit details
    Browse the repository at this point in the history

  2. Fix the failed return value, which should still be null.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    5749d57 View commit details
    Browse the repository at this point in the history

  3. Replace return with break. 

    The server body here is inside a closure with a while loop. It
appears that the original commit wanted to have a way to terminate
the server gracefully by doing a non-local return that should
bubble out. However, when using a threaded server the result is
a LocalJumpError since return is not valid in a thread.

We believe this should be a break instead of a return, since it
just wants to escape the request-handling loop. This change allows
MRI trunk tests for net/http to pass on JRuby the same way they
did before.
    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    ce7e292 View commit details
    Browse the repository at this point in the history