Fix #13528 : SOAP API accesses undefined variable in error handling

atrol · atrol · commit b272eaad5940 · 2011-11-11T16:45:35.000+01:00
diff --git a/api/soap/mc_file_api.php b/api/soap/mc_file_api.php
@@ -192,16 +192,16 @@ function mci_file_get( $p_file_id, $p_type, $p_user_id ) {
 	switch( $p_type ) {
 		case 'bug':
 			if( !mci_file_can_download_bug_attachments( $t_bug_id, $p_user_id ) ) {
-				return mci_soap_fault_access_denied( $t_user_id );
+				return mci_soap_fault_access_denied( $p_user_id );
 			}
 			break;
 		case 'doc':
 			# Check if project documentation feature is enabled.
 			if( OFF == config_get( 'enable_project_documentation' ) ) {
-				return mci_soap_fault_access_denied( $t_user_id );
+				return mci_soap_fault_access_denied( $p_user_id );
 			}
 			if( !access_has_project_level( config_get( 'view_proj_doc_threshold' ), $t_project_id, $p_user_id ) ) {
-				return mci_soap_fault_access_denied( $t_user_id );
+				return mci_soap_fault_access_denied( $p_user_id );
 			}
 			break;
 	}

Original file line number	Diff line number	Diff line change
`@@ -192,16 +192,16 @@ function mci_file_get( $p_file_id, $p_type, $p_user_id ) {`
`192`	`192`	`switch( $p_type ) {`
`193`	`193`	`case 'bug':`
`194`	`194`	`if( !mci_file_can_download_bug_attachments( $t_bug_id, $p_user_id ) ) {`
`195`		`- return mci_soap_fault_access_denied( $t_user_id );`
	`195`	`+ return mci_soap_fault_access_denied( $p_user_id );`
`196`	`196`	`}`
`197`	`197`	`break;`
`198`	`198`	`case 'doc':`
`199`	`199`	`# Check if project documentation feature is enabled.`
`200`	`200`	`if( OFF == config_get( 'enable_project_documentation' ) ) {`
`201`		`- return mci_soap_fault_access_denied( $t_user_id );`
	`201`	`+ return mci_soap_fault_access_denied( $p_user_id );`
`202`	`202`	`}`
`203`	`203`	`if( !access_has_project_level( config_get( 'view_proj_doc_threshold' ), $t_project_id, $p_user_id ) ) {`
`204`		`- return mci_soap_fault_access_denied( $t_user_id );`
	`204`	`+ return mci_soap_fault_access_denied( $p_user_id );`
`205`	`205`	`}`
`206`	`206`	`break;`
`207`	`207`	`}`