Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: ecf9f606c954
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 532d9929c7e6
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Mar 5, 2013

  1. cluster: propagate bind errors 

    This commit fixes a bug where the cluster module fails to propagate
EADDRINUSE errors.

When a worker starts a (net, http) server, it requests the listen socket
from its master who then creates and binds the socket.

Now, OS X and Windows don't always signal EADDRINUSE from bind() but
instead defer the error until a later syscall. libuv mimics this
behaviour to provide consistent behaviour across platforms but that
means the worker could end up with a socket that is not actually bound
to the requested addresss.

That's why the worker now checks if the socket is bound, raising
EADDRINUSE if that's not the case.

Fixes #2721.
    @bnoordhuis
    bnoordhuis committed Mar 5, 2013
    Copy the full SHA
    532d992 View commit details
    Browse the repository at this point in the history