Fix #0009034: CSV Export with special chars dont work properly

VeMag · rombert · commit 4fd535680fc3 · 2011-12-23T11:54:13.000+02:00
Adding "Byte Order Mark" at the begining of the file resolves the issue.

$g_csv_add_bom parameter with default = OFF, because of remarks on pull request 27

Signed-off-by: Robert Munteanu &lt;robert.munteanu@gmail.com&gt;
diff --git a/config_defaults_inc.php b/config_defaults_inc.php
@@ -2701,6 +2701,13 @@
 	 */
 	$g_csv_separator = ',';
 
+	/**
+	  * CSV Export
+	  * Add Byte Order Mark (BOM) at the begining of the file as it helps Excel display the file in UTF-8
+	  * @global string $g_csv_add_bom
+	  */
+	$g_csv_add_bom = OFF;
+
 	/**
 	 * threshold for users to view the system configurations
 	 * @global int $g_view_configuration_threshold
diff --git a/csv_export.php b/csv_export.php
@@ -63,6 +63,11 @@
 	# Get columns to be exported
 	$t_columns = csv_get_columns();
 
+	# export BOM
+	if ( config_get( 'csv_add_bom' ) == ON ) {
+		echo "\xEF\xBB\xBF";
+	}
+
 	# export the titles
 	$t_first_column = true;
 	ob_start();
diff --git a/docbook/adminguide/en/configuration.sgml b/docbook/adminguide/en/configuration.sgml
@@ -2336,6 +2336,14 @@
                     </para>
                 </listitem>
             </varlistentry>
+            <varlistentry>
+                <term>$g_csv_add_bom</term>
+                <listitem>
+                    <para>Add Byte Order Mark (BOM) at the begining of the file as it helps Excel display the file in UTF-8.
+                    The default value is OFF;
+                    </para>
+                </listitem>
+            </varlistentry>
         </variablelist>
     </section>
 
