Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 3d4c663ee683
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: f31037ddfefd
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 14, 2013

  1. http: don't pass the request options to Agent 

    The `options` that were being passed in before here are specific to a
single request, which kinda defeats the purpose of using an Agent in the
first place.

On a worse note, these `options` have not yet been "processed" by the
`http.ClientRequest` class, so if `port: null` is set (like it is as the
result of a `url.parse()` call), then they take preference over the
processed values since the agent's "options" get mixed in last in the
`createSocket()` function.

Fixes #6197.
Fixes #6199.
Closes #6231.
    @TooTallNate
    TooTallNate committed Sep 14, 2013
    Copy the full SHA
    f31037d View commit details
    Browse the repository at this point in the history