Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): add option to disable animations #2725

Merged
merged 1 commit into from Mar 30, 2015
Merged

feat(modal): add option to disable animations #2725

merged 1 commit into from Mar 30, 2015

Conversation

chrisirhc
Copy link
Contributor

Add ability to disable animations. Built on top of #2724 .

@chrisirhc chrisirhc mentioned this pull request Oct 6, 2014
Closed
@dvdplm
Copy link

dvdplm commented Oct 16, 2014

I'd love to see this get merged.

@ruchevits
Copy link

+1

2 similar comments
@dotnetwise
Copy link

+1

@danhollingshead
Copy link

+1

@chrisirhc chrisirhc added this to the Backlog milestone Nov 7, 2014
@vanthoom
Copy link

+1

1 similar comment
@marcusvetter
Copy link

+1

@andrewboni
Copy link

+1, can we get this merged?

@karianna
Copy link
Contributor

@chrisirhc are you able to update the PR - it can't be auto merged / cherry picked.

@chrisguerrero
Copy link

+1

Any word on this?

@karianna
Copy link
Contributor

https://github.com/angular-ui/bootstrap#impt---2015-plans-and-angular-13-support

@chrisirhc
Copy link
Contributor Author

Will rebase it in a short while, after I rebase #2724 .

@wesleycho wesleycho modified the milestones: 0.13.0, Backlog Mar 23, 2015
@wesleycho
Copy link
Contributor

Moved milestone to 0.13.0 - sounds like we can get this in for the next release.

@wesleycho
Copy link
Contributor

How much work is left on this PR @chrisirhc ?

@chrisirhc chrisirhc force-pushed the feature/modal-disable-animation branch from 061ec62 to 05f4bbe Compare March 30, 2015 07:53
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this pull request Mar 30, 2015
@chrisirhc
feat(modal): add option to disable animations
05f4bbe 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
@chrisirhc
feat(modal): add option to disable animations
5e661d4 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
@chrisirhc chrisirhc force-pushed the feature/modal-disable-animation branch from 05f4bbe to 5e661d4 Compare March 30, 2015 07:59
@chrisirhc chrisirhc merged commit 5e661d4 into angular-ui:master Mar 30, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 9, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
3c6eb1d 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
7f673aa 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
f3baaa7 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
59cd1c3 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
1621f71 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
789bdea 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
55ba839 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
e021a8b 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
f6a5fdc 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
8c1396b 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
73e0d3c 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
3971c5a 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
8d1d893 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
@chrisirhc @fernando-sendMail
feat(modal): add option to disable animations
21d761b 
Note: Move backdropClass logic into compile function because otherwise
modifying classes in the compile function is broken when using an interpolated
class attribute.

Fixes angular-ui#1007
Closes angular-ui#2725
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: modal
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

Successfully merging this pull request may close these issues.

None yet