Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 6902f6536cee
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 7124387b3414
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on May 15, 2013

  1. net: emit dns 'lookup' event before connect 

    net.connect() and net.createConnection() now emit a 'lookup' event
after resolving the hostname but before connecting.

Fixes #5418.
    @bnoordhuis
    bnoordhuis committed May 15, 2013
    Copy the full SHA
    b3d1e50 View commit details
    Browse the repository at this point in the history

  2. http: don't escape request path, reject bad chars 

    Commit 38149bb changes http.get() and http.request() to escape unsafe
characters. However, that creates an incompatibility with v0.10 that
is difficult to work around: if you escape the path manually, then in
v0.11 it gets escaped twice. Change lib/http.js so it no longer tries
to fix up bad request paths, simply reject them with an exception.

The actual check is rather basic right now. The full check for illegal
characters is difficult to implement efficiently because it requires a
few characters of lookahead. That's why it currently only checks for
spaces because those are guaranteed to create an invalid request.

Fixes #5474.
    @bnoordhuis
    bnoordhuis committed May 15, 2013
    Copy the full SHA
    7124387 View commit details
    Browse the repository at this point in the history