Even mo better exception handling

fcrepo · Apr 21, 2013 · 66659a3 · 66659a3
1 parent 0efb875
commit 66659a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/fcrepo-metrics/src/main/java/org/fcrepo/metrics/RegistryService.java b/fcrepo-metrics/src/main/java/org/fcrepo/metrics/RegistryService.java
@@ -7,9 +7,9 @@
 import com.yammer.metrics.MetricFilter;
 import com.yammer.metrics.MetricRegistry;
 
-public class RegistryService {
+public abstract class RegistryService {
 
-    private final static MetricRegistry metrics = new MetricRegistry("fcrepo");
+    private static final MetricRegistry metrics = new MetricRegistry("fcrepo");
 
     public static MetricRegistry getMetrics() {
         return metrics;

diff --git a/fcrepo-metrics/src/main/java/org/fcrepo/metrics/ReporterFactory.java b/fcrepo-metrics/src/main/java/org/fcrepo/metrics/ReporterFactory.java
@@ -1,7 +1,9 @@
 
 package org.fcrepo.metrics;
 
-import java.util.concurrent.TimeUnit;
+import static com.yammer.metrics.graphite.GraphiteReporter.forRegistry;
+import static java.util.concurrent.TimeUnit.MINUTES;
+import static org.fcrepo.metrics.RegistryService.getMetrics;
 
 import com.yammer.metrics.ScheduledReporter;
 import com.yammer.metrics.graphite.Graphite;
@@ -11,11 +13,8 @@ public class ReporterFactory {
 
     public ScheduledReporter registerGraphiteReporter(final Graphite g,
             final String prefix) {
-        final GraphiteReporter r =
-                GraphiteReporter.forRegistry(RegistryService.getMetrics())
-                        .build(g);
-
-        r.start(1, TimeUnit.MINUTES);
+        final GraphiteReporter r = forRegistry(getMetrics()).build(g);
+        r.start(1, MINUTES);
         return r;
     }