Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 41c7d185567a
Choose a base ref
...
head repository: opal/opal-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4ab607726df3
Choose a head ref
  • 5 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 11, 2014

  1. Fix slightly misleading instructions. 

    I don't think `require opal-jquery` needs to be `require`d explicitly for the DOM manipulation example. However, `Document.ready?` should be in there.
    @benjamintanweihao
    benjamintanweihao committed Mar 11, 2014
    Copy the full SHA
    fe79db6 View commit details

  2. Re-add require 'opal-jquery'

    @benjamintanweihao
    benjamintanweihao committed Mar 11, 2014
    Copy the full SHA
    70edef8 View commit details

Commits on Mar 12, 2014

  1. Added missing 'do'

    @benjamintanweihao
    benjamintanweihao committed Mar 12, 2014
    Copy the full SHA
    08468ed View commit details

  2. Merge pull request #1 from benjamintanweihao/patch-2 

    Added missing 'do'
    @benjamintanweihao
    benjamintanweihao committed Mar 12, 2014
    Copy the full SHA
    1c42388 View commit details

  3. Merge pull request #22 from benjamintanweihao/patch-1 

    Fix slightly misleading instructions.
    @elia
    elia committed Mar 12, 2014
    Copy the full SHA
    4ab6077 View commit details
Showing with 3 additions and 1 deletion.
  1. +3 −1 README.md
4 changes: 3 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -73,7 +73,9 @@ puts "G'day world!" # check the console!
# Dom manipulation
require 'opal-jquery'

Element.find('body > header').html = '<h1>Hi there!</h1>'
Document.ready? do
Element.find('body > header').html = '<h1>Hi there!</h1>'
end
```