Skip to content

Commit 476238d

Browse files
adambeynonadambeynon
committedOct 30, 2013
Add yet more string specs from rubyspec
·
v1.8.3.rc1lerna-0.0.1-alpha.2
1 parent a8a216f commit 476238d

File tree

9 files changed

+60
-120
lines changed

9 files changed

+60
-120
lines changed
 

‎spec/corelib/string/capitalize_spec.rb

-10
This file was deleted.

‎spec/corelib/string/casecmp_spec.rb

-16
This file was deleted.

‎spec/corelib/string/center_spec.rb

-46
This file was deleted.

‎spec/corelib/string/chomp_spec.rb

-48
This file was deleted.

‎spec/filters/bugs/string.rb

+8
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,12 @@
2626
fails "String#downcase is locale insensitive (only replaces A-Z)"
2727
fails "String#intern does not special case certain operators"
2828
fails "String#to_sym does not special case certain operators"
29+
fails "String#capitalize is locale insensitive (only upcases a-z and only downcases A-Z)"
30+
fails "String#center with length, padding raises an ArgumentError if padstr is empty"
31+
fails "String#center with length, padding raises a TypeError when padstr can't be converted to a string"
32+
fails "String#center with length, padding calls #to_str to convert padstr to a String"
33+
fails "String#center with length, padding raises a TypeError when length can't be converted to an integer"
34+
fails "String#center with length, padding calls #to_int to convert length to an integer"
35+
fails "String#chomp when passed an Object raises a TypeError if #to_str does not return a String"
36+
fails "String#chomp when passed no argument returns a copy of the String when it is not modified"
2937
end

‎spec/filters/unsupported/mutable_strings.rb

+35
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,39 @@
1111
fails "String#downcase! raises a RuntimeError when self is frozen"
1212
fails "String#downcase! returns nil if no modifications were made"
1313
fails "String#downcase! modifies self in place"
14+
fails "String#capitalize! raises a RuntimeError when self is frozen"
15+
fails "String#capitalize! returns nil when no changes are made"
16+
fails "String#capitalize! capitalizes self in place"
17+
fails "String#chomp! when passed a String does not taint the result when the argument is tainted"
18+
fails "String#chomp! when passed a String taints the result if self is tainted"
19+
fails "String#chomp! when passed a String returns nil when self is empty"
20+
fails "String#chomp! when passed a String returns nil if the argument does not match the trailing characters"
21+
fails "String#chomp! when passed a String removes the trailing characters if they match the argument"
22+
fails "String#chomp! when passed an Object raises a TypeError if #to_str does not return a String"
23+
fails "String#chomp! when passed an Object calls #to_str to convert to a String"
24+
fails "String#chomp! when passed '\\n' returns nil when self is empty"
25+
fails "String#chomp! when passed '\\n' taints the result if self is tainted"
26+
fails "String#chomp! when passed '\\n' removes one trailing carrige return, newline pair"
27+
fails "String#chomp! when passed '\\n' removes one trailing carriage return"
28+
fails "String#chomp! when passed '\\n' removes one trailing newline"
29+
fails "String#chomp! when passed '' returns nil when self is empty"
30+
fails "String#chomp! when passed '' taints the result if self is tainted"
31+
fails "String#chomp! when passed '' removes more than one trailing carriage return, newline pairs"
32+
fails "String#chomp! when passed '' removes more than one trailing newlines"
33+
fails "String#chomp! when passed '' does not remove a final carriage return"
34+
fails "String#chomp! when passed '' removes a final carriage return, newline"
35+
fails "String#chomp! when passed '' removes a final newline"
36+
fails "String#chomp! when passed nil returns nil when self is empty"
37+
fails "String#chomp! when passed nil returns nil"
38+
fails "String#chomp! when passed no argument removes trailing characters that match $/ when it has been assigned a value"
39+
fails "String#chomp! when passed no argument returns subclass instances when called on a subclass"
40+
fails "String#chomp! when passed no argument taints the result if self is tainted"
41+
fails "String#chomp! when passed no argument returns nil when self is empty"
42+
fails "String#chomp! when passed no argument removes one trailing carrige return, newline pair"
43+
fails "String#chomp! when passed no argument removes one trailing carriage return"
44+
fails "String#chomp! when passed no argument removes one trailing newline"
45+
fails "String#chomp! when passed no argument returns nil if self is not modified"
46+
fails "String#chomp! when passed no argument modifies self"
47+
fails "String#chomp! raises a RuntimeError on a frozen instance when it would not be modified"
48+
fails "String#chomp! raises a RuntimeError on a frozen instance when it is modified"
1449
end

‎spec/filters/unsupported/string_subclasses.rb

+3
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,7 @@
22
fails "String#upcase returns a subclass instance for subclasses"
33
fails "String#swapcase returns subclass instances when called on a subclass"
44
fails "String#downcase returns a subclass instance for subclasses"
5+
fails "String#capitalize returns subclass instances when called on a subclass"
6+
fails "String#center with length, padding returns subclass instances when called on subclasses"
7+
fails "String#chomp when passed no argument returns subclass instances when called on a subclass"
58
end

‎spec/filters/unsupported/tainted.rb

+10
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,14 @@
5050

5151
fails "Pathname.new is tainted if path is tainted"
5252
fails "String#downcase taints result when self is tainted"
53+
fails "String#capitalize taints resulting string when self is tainted"
54+
fails "String#center with length, padding when padding is tainted and self is untainted returns a tainted string if and only if length is longer than self"
55+
fails "String#center with length, padding taints result when self or padstr is tainted"
56+
fails "String#chomp when passed a String does not taint the result when the argument is tainted"
57+
fails "String#chomp when passed a String taints the result if self is tainted"
58+
fails "String#chomp when passed '\\n' taints the result if self is tainted"
59+
fails "String#chomp when passed '' taints the result if self is tainted"
60+
fails "String#chomp when passed nil taints the result if self is tainted"
61+
fails "String#chomp when passed nil returns a copy of the String"
62+
fails "String#chomp when passed no argument taints the result if self is tainted"
5363
end

‎spec/rubyspecs

+4
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,10 @@ core/matchdata/to_a_spec
224224
core/range/begin_spec
225225
core/range/end_spec
226226

227+
core/string/capitalize_spec
228+
core/string/casecmp_spec
229+
core/string/center_spec
230+
core/string/chomp_spec
227231
core/string/downcase_spec
228232
core/string/empty_spec
229233
core/string/end_with_spec

0 commit comments

Comments
 (0)
Please sign in to comment.