Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7bc449c06329
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ec378aaa690d
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Feb 27, 2013

  1. core: Use a uv_signal for debug listener

    Starting the debugger directly in the SIGUSR1 signal handler results in
    a malloc lock contention ~1% of the time.  It hangs the test, which is
    annoying on a daily basis to all of us, but it also is pretty terrible
    if you actually want to debug a node process that has gone sideways.
    
    Credit to @bnoordhuis for most of this.  I just added the unref which
    keeps it from messing up the event loop for other stuff.
    isaacs committed Feb 27, 2013
    Copy the full SHA
    30e5366 View commit details
    Browse the repository at this point in the history
  2. test: catch break in simple/test-debugger-client

    Handle break events that come out sometimes, by telling it to continue.
    
    Also, send the child a SIGTERM when it times out.
    isaacs committed Feb 27, 2013
    Copy the full SHA
    57f9f04 View commit details
    Browse the repository at this point in the history
  3. test: Fix debugger repl tests

    This makes the output of simple/test-debugger-repl and
    simle/test-debugger-repl-utf8 mirror an actual debugger session, so it's
    a bit easier to reason about.
    
    Also, it uses the same code for both, and fixes it so that it doesn't
    leave zombie processes lying around when it crashes.
    
    Run 1000 times without any failures or zombies.
    isaacs committed Feb 27, 2013
    Copy the full SHA
    ec378aa View commit details
    Browse the repository at this point in the history