Improving the formatting for: Provider.toString() implementation should

dkayiwa · dkayiwa · commit d515c5a52468 · 2013-07-31T14:56:22.000+03:00
return the id as well as provider names - TRUNK-3736
diff --git a/api/src/main/java/org/openmrs/Provider.java b/api/src/main/java/org/openmrs/Provider.java
@@ -107,8 +107,9 @@ public String getIdentifier() {
 	public String toString() {
 		StringBuilder sb = new StringBuilder();
 		sb.append(providerId);
+		sb.append(" providerName:");
 		sb.append((person != null) ? person.getNames() : "");
-		return "[Provider: providerId: " + sb.toString() + " ]";
+		return "[Provider: providerId:" + sb.toString() + " ]";
 	}
 	
 	/**
diff --git a/api/src/test/java/org/openmrs/ProviderTest.java b/api/src/test/java/org/openmrs/ProviderTest.java
@@ -76,7 +76,7 @@ public void toString_shouldReturnPersonAllNamesWithSpecificFormat() throws Excep
 		Person person = new Person(1);
 		person.addName(new PersonName("givenName", "middleName", "familyName"));
 		provider.setPerson(person);
-		Assert.assertEquals(provider.toString(), "[Provider: providerId: 1[givenName middleName familyName] ]");
+		Assert.assertEquals(provider.toString(), "[Provider: providerId:1 providerName:[givenName middleName familyName] ]");
 	}
 	
 }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public void toString_shouldReturnPersonAllNamesWithSpecificFormat() throws Excep`
`76`	`76`	`Person person = new Person(1);`
`77`	`77`	`person.addName(new PersonName("givenName", "middleName", "familyName"));`
`78`	`78`	`provider.setPerson(person);`
`79`		`- Assert.assertEquals(provider.toString(), "[Provider: providerId: 1[givenName middleName familyName] ]");`
	`79`	`+ Assert.assertEquals(provider.toString(), "[Provider: providerId:1 providerName:[givenName middleName familyName] ]");`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`}`