Navigation Menu

Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 586e160a2583
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 86433979c6f3
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 27, 2013

  1. stream: Writables are not pipe()able 

    This handles the fact that stream.Writable inherits from the Stream class,
meaning that it has the legacy pipe() method.  Override that with a pipe()
method that emits an error.

Ensure that Duplex streams ARE still pipe()able, however.

Since the 'readable' flag on streams is sometimes temporary, it's probably
better not to put too much weight on that.  But if something is an instanceof
Writable, rather than of Readable or Duplex, then it's safe to say that
reading from it is the wrong thing to do.

Fix #3647
    @isaacs
    isaacs committed Feb 27, 2013
    Copy the full SHA
    8643397 View commit details
    Browse the repository at this point in the history