Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: c657dac5d5c1
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 66b243dd8750
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 1, 2015

  1. test: relax the timing window in test-child-process-fork-net2.js

    In Linux, simple/test-child-process-fork-net2.js fails intermittently.
    
    In SuSE Linux system, under network high load situations, this failure is
    consistently reproducible.
    
    The test case tests whether the TCP connections which were established between
    the processes terminate in a timely and clean manner. After some iterations of
    data transfer on established connections, the server is closed. The server does
    not get closed immediately, instead waits for all the active connections to
    terminate. A timed (200ms) callback closes the connections, which eventually
    closes the server.
    
    The start is the time when the server close is invoked.
    The end is the time when the server is actually closed(onClose call back invoked).
    
    Given that there is a minimum delay of 200ms before the connections are
    terminated, expecting the elapsed time above 190 is reasonable and fair,
    but looks like the leeway of 800ms for the upper bounds seem to be too
    stringent, and breaking some scenarios of network load.
    
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    PR-URL: #14129
    gireeshpunathil authored and mhdawson committed Apr 1, 2015
    Copy the full SHA
    66b243d View commit details
    Browse the repository at this point in the history