Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR improperly masks errors in defined-guarded conditional #2776

Closed
headius opened this issue Mar 29, 2015 · 2 comments
Closed

IR improperly masks errors in defined-guarded conditional #2776

headius opened this issue Mar 29, 2015 · 2 comments
Labels
ir JRuby 9000
Milestone
JRuby 9.0.0.0.pre2

Comments

@headius
Copy link
Member

headius commented Mar 29, 2015

This code raises NotImplementedError running under the JIT, but completes successfully (incorrectly) under IR interpreter:

if defined?(Process::RLIMIT_AS)
  Process.rlimit # This should raise
end

I have not started examining the IR this is producing, nor why it works properly in JIT.
@headius headius added this to the JRuby 9.0.0.0 milestone Mar 29, 2015
@headius
Copy link
Member Author

headius commented Mar 29, 2015

Tagging @subbuss and @enebo.

headius added a commit that referenced this issue Mar 29, 2015
@headius
This never actually worked but was masked by #2776.
48b2185
@headius
Copy link
Member Author

headius commented Mar 29, 2015

@subbuss Very nice :-) I was going to circle back to this after today's audit, but yay for having it fixed!

@headius headius modified the milestones: 9.0.0.0.pre2, JRuby 9.0.0.0 Mar 29, 2015
@subbuss subbuss mentioned this issue May 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ir JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

No branches or pull requests
1 participant
@headius