Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined group option during parse of mri/test_regexp.rb #2777

Closed
headius opened this issue Mar 29, 2015 · 4 comments
Closed

Undefined group option during parse of mri/test_regexp.rb #2777

headius opened this issue Mar 29, 2015 · 4 comments
Labels
JRuby 9000 parser ruby 2.0-2.2
Milestone
JRuby 9.0.0.0.pre2

Comments

@headius
Copy link
Member

headius commented Mar 29, 2015

The following regexp does not parse/compile: /\A((x)|(y))(?(2)y|x)\z/

Here's the error it produces:

[] ~/projects/jruby $ jruby -c test/mri/ruby/test_regexp.rb 
SyntaxError in (RegexpError) undefined group option: /\A((x)|(y))(?(2)y|x)\z/

As you can see this prevents test_regexp.rb from running. It has not been running for over a year (excluded from test:mri run) and we should really fix this for 9k final.
@headius headius added this to the JRuby 9.0.0.0 milestone Mar 29, 2015
@lopex
Copy link
Contributor

lopex commented Mar 29, 2015

Onigmo merge: ruby/ruby@0424e15

@lopex
Copy link
Contributor

lopex commented Apr 1, 2015

Implemented in jruby/joni@8d41393, conditionals specific tests pending...

@headius
Copy link
Member Author

headius commented Apr 2, 2015

Working on getting test_regexp going now, and then I'll resolve this.

@headius
Copy link
Member Author

headius commented Apr 2, 2015

joni 2.1.6-SNAPSHOT has been deployed.

headius added a commit that referenced this issue Apr 2, 2015
@headius
Update to joni-2.1.6-SNAPSHOT for #2777.
2bf3974
headius added a commit that referenced this issue Apr 2, 2015
@headius
Enable test_regexp.rb for #2777 and update excludes.
7f5ea0a
@headius headius modified the milestones: 9.0.0.0.pre2, JRuby 9.0.0.0 Apr 2, 2015
@headius headius closed this as completed Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JRuby 9000 parser ruby 2.0-2.2
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

No branches or pull requests
2 participants
@headius @lopex